Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce the P7 to P8 update. #1301

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Introduce the P7 to P8 update. #1301

merged 3 commits into from
Jan 8, 2025

Conversation

eb-concordium
Copy link
Contributor

@eb-concordium eb-concordium commented Dec 11, 2024 •
edited
Loading

Purpose

To implement what is left of #1294.
So far a dummy hash for the update is given. This MUST be updated when Concordium/concordium-update-proposals#69 has been merged.

Changes

  • P7 to P8 update introduced.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@eb-concordium eb-concordium requested a review from drsk0 December 11, 2024 19:35
drsk0
drsk0 requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@drsk0 drsk0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a problem with rebooting the wrong protocol version. Other than that it looks good.

@eb-concordium eb-concordium requested a review from td202 January 6, 2025 13:23
@td202
Copy link
Contributor

td202 commented Jan 6, 2025

Also update changelog.

@eb-concordium eb-concordium merged commit 21bf0bf into main Jan 8, 2025
3 checks passed
@eb-concordium eb-concordium deleted the p7-to-p8-update branch January 8, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drsk0 drsk0 drsk0 approved these changes

@td202 td202 td202 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eb-concordium @td202 @drsk0